From: Florian Müllner <fmuellner@gnome.org>
Date: Thu, 22 May 2025 01:25:00 +0000 (+0200)
Subject: dbusServices/extensions: Mention extension name in description
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~116^2^2~16
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=98aafd2c14d899a39f3ecfc8015c5ef5802d9542;p=gnome-shell.git

dbusServices/extensions: Mention extension name in description

The extension name is still useful information, so mention it in
the description now that it is no longer in the title.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3750>
---

diff --git a/js/dbusServices/extensions/extensionPrefsDialog.js b/js/dbusServices/extensions/extensionPrefsDialog.js
index 284ae0b97..01d6258f2 100644
--- a/js/dbusServices/extensions/extensionPrefsDialog.js
+++ b/js/dbusServices/extensions/extensionPrefsDialog.js
@@ -81,6 +81,7 @@ class ExtensionPrefsErrorPage extends Adw.PreferencesPage {
         'resource:///org/gnome/Shell/Extensions/ui/extension-error-page.ui';
 
     static [Gtk.internalChildren] = [
+        'descriptionLabel',
         'expander',
         'expanderArrow',
         'revealer',
@@ -106,11 +107,18 @@ class ExtensionPrefsErrorPage extends Adw.PreferencesPage {
 
         this._addCustomStylesheet();
 
-        this._uuid = extension.uuid;
-        this._url = extension.metadata.url || '';
+        const {uuid, name, url} = extension.metadata;
+
+        this._url = url;
 
         this.action_set_enabled('page.show-url', this._url !== '');
 
+        const label =
+            /* Translators: %s is an extension name */
+            _('Unable to display the settings for “%s”.')
+                .format(GLib.markup_escape_text(name, -1));
+        this._descriptionLabel.set({label});
+
         this._gesture = new Gtk.GestureClick({
             button: 0,
             exclusive: true,
@@ -136,7 +144,7 @@ class ExtensionPrefsErrorPage extends Adw.PreferencesPage {
 
         // markdown for pasting in gitlab issues
         let lines = [
-            `The settings of extension ${this._uuid} had an error:`,
+            `The settings of extension ${uuid} had an error:`,
             '```',
             formattedError.replace(/\n$/, ''),  // remove trailing newline
             '```',
diff --git a/js/dbusServices/extensions/ui/extension-error-page.ui b/js/dbusServices/extensions/ui/extension-error-page.ui
index 012b6b8f0..7648eb428 100644
--- a/js/dbusServices/extensions/ui/extension-error-page.ui
+++ b/js/dbusServices/extensions/ui/extension-error-page.ui
@@ -11,10 +11,10 @@
             <property name="orientation">vertical</property>
             <property name="spacing">12</property>
             <child>
-              <object class="GtkLabel">
-                <property name="label" translatable="yes">We’re very sorry, but there’s been a problem: the settings for this extension can’t be displayed. We recommend that you report the issue to the extension authors.</property>
+              <object class="GtkLabel" id="descriptionLabel">
                 <property name="justify">center</property>
                 <property name="wrap">True</property>
+                <property name="use-markup">True</property>
               </object>
             </child>
             <child>